Skip to content

Commit

Permalink
github: Skip clang-analyze when reference generation fails.
Browse files Browse the repository at this point in the history
Compiling the OVS reference is supposed to succeed unless some external
change breaks this compilation.

One example is when DPDK API changes and breaks OVS compilation.
This case is hit in the dpdk-latest branch, but also when bumping DPDK
version in the main branch.

On the other hand, the clang-analyze check goal is to validate OVS
changes, not external changes.

Fixes: d662eee ("ci: Add clang-analyze to GitHub actions.")
Signed-off-by: David Marchand <[email protected]>
  • Loading branch information
david-marchand committed Nov 21, 2024
1 parent dc7663f commit 8d855fc
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -432,17 +432,22 @@ jobs:
run: ./.ci/linux-prepare.sh

- name: build base reference
id: base_reference_build
if: steps.clang_cache.outputs.cache-hit != 'true'
continue-on-error: true
run: ./.ci/linux-build.sh

- name: save cache
uses: actions/cache/save@v4
if: steps.clang_cache.outputs.cache-hit != 'true'
if: steps.clang_cache.outputs.cache-hit != 'true' && \
steps.base_reference_build.outcome == 'success'
with:
path: base-clang-analyzer-results
key: ${{ steps.cache_key.outputs.key }}

- name: build
if: steps.clang_cache.outputs.cache-hit == 'true' || \
steps.base_reference_build.outcome == 'success'
run: ./.ci/linux-build.sh

build-oss-fuzz:
Expand Down

0 comments on commit 8d855fc

Please sign in to comment.