Delayed and enlarged unhighlight transitions. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defer and enlarge in time the clickable widget unhighlighting. It's hard to explain why, but I think it is more visually pleasant, more smooth. You can try to catch the difference by reverting this commit. I want to do the same to the 'edit deck / new deck' facility, but because those are cairo canvases, it will take me a lot more time and lines to do it there.
Add the basic framework for being able to set smooth un/highlight visual transitions for the `Create Deck` widget canvas.
Configure delays and transitions using 37cc4ea as model.
Prepare for the code for applying smooth transitions to `library_deck_summary`. Argument `show_name` starts being mandatory, because a second argument `creating` will be introduced without default value.
Prepare the code for applying smooth transitions to `library_deck_summary`. Add the `creating` argument.
Apply to `library_deck_summary` code changes applied to `library_new_deck` by rev 14f5840.
Changes for investigating why the changes in the _deck summary_ facility do not show smooth as in the _new deck_ facility. Configure large delays and transitions to better understand what is happening.
It seems the rendering must be triggered by `fire_event`. So make the `render(...)` function as being of one single argument that is the packed list of its previous arguments. This is because even though `bind_command` can receive a variable argument count, when using `fire_event` Anura can only pass one single argument.
Make the `show_name` argument optional back again, and make the new `creating` argument optional.
library_deck_summary: disable caching and magically everything starts working, but FPS suffers.
Not sure why, when using the cache but caching `step` it works too. FPS keeps suffering.
Misc fixes.
Apply 1cdef26 to `data/objects/library_new_deck`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel that unhighlighting transitions look better when delayed, 2ff42eb is changing them.
The canvases at the Library weren't having animation support (I guess), all those other commits are for providing that.
I'm sorry this got complicated.