Truncate name to 64 characters #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use last 64 characters for significant bits, as our use-case is paths, and they're more specific as they get longer...
This was referenced Jun 26, 2017
|
Rather than truncating, I'd prefer to simply throw. devcert is designed to be a low-level library, and I don't think we necessarily want to assume that a name longer than 64 characters should simply be truncated. If the consuming library / framework / tool wants to truncate, it can do that. I appreciate the issue and PR though! Wasn't aware of that restriction in OpenSSL. A PR for throwing would be more than welcome! |
alias-mac
pushed a commit
to alias-mac/devcert
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use last 64 characters for significant bits, as our use-case is paths, and
they're more specific as they get longer...