Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add proper generics to accessors #58

Merged
merged 2 commits into from
Jun 22, 2019

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented May 1, 2019

see #38, #38 (comment)

@gil0mendes @ozum you were close

@KaelWD KaelWD force-pushed the fix/accessor-types branch from 469cfd5 to df3328f Compare May 1, 2019 01:12
@davestewart
Copy link
Owner

Hey @KaelWD,

Thanks for this. That sure is pretty code! I've been doing typescript for while, but not to this level.

Do you have any resources for where to learn about doing code like you've written in your tests?

I didn't even know you could do this:

Vue.extend({
  computed: get<{
    search: string,
    items: any[]
  }>('products', [
    'search',
    'items',
  ]),

@KaelWD
Copy link
Contributor Author

KaelWD commented May 8, 2019

If you mean specifically with vue, I don't think there really are any. Otherwise it's mostly just writing TS every day for the past ~year plus a little help from here.

@KaelWD
Copy link
Contributor Author

KaelWD commented Jun 22, 2019

Is this ready to merge?

@davestewart
Copy link
Owner

davestewart commented Jun 22, 2019

Sorry @KaelWD - been really distracted with other things.

@davestewart davestewart merged commit 407bf23 into davestewart:develop Jun 22, 2019
@davestewart
Copy link
Owner

Published :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants