Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typeof instead of instanceof to check for functions (fix for [vuex] unknown local mutation type) #46

Merged
merged 1 commit into from
Feb 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/helpers/accessors.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function (store) {
const getter = makeGetter(store, path)
if (typeof getter !== 'undefined') {
const value = getter()
return value instanceof Function
return typeof value === 'function'
? value(...args)
: value
}
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/store.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import Payload from '../classes/Payload'
* @returns {Array}
*/
function getStateKeys (state) {
return getKeys(state instanceof Function ? state() : state)
return getKeys(typeof state === 'function' ? state() : state)
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/plugin/debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function debug () {
console.log(`
[Vuex Pathify] Options:

Mapping (${options.mapping instanceof Function ? 'custom' : options.mapping})
Mapping (${typeof options.mapping === 'function' ? 'custom' : options.mapping})
-------------------------------
path : value
state : ${resolve('state')}
Expand Down
2 changes: 1 addition & 1 deletion src/services/resolver.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export function resolveName (type, name) {

// unconfigured resolver! (runs once)
if (!fn) {
if (options.mapping instanceof Function) {
if (typeof options.mapping === 'function') {
fn = options.mapping
}
else {
Expand Down