Demand doobie Put/Get as separate constraints #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the Doobie documentation on Meta, > It's important to understand that `Meta` should never be demanded by user methods; instead demand both `Get` and `Put`. The reason for this is that while `Meta` implies `Get` and `Put`, the presence of both `Get` and `Put` does *not* imply `Meta`. This commit separates the constraints for the `FUUID` `Meta` instance, adding a new implicit definition and deprecating the old one.
ChristopherDavenport
approved these changes
Mar 2, 2021
|
@ChristopherDavenport any change we could merge this, bump doobie to 0.12.1 and do a release in the near term? It looks like Doobie 0.10.0 is binary incompatible with 0.12.1. |
|
Probably low priority though, it looks like the very small binary API we call here is backwards compatible. Sorry, I got ahead of myself there. |
|
@ChristopherDavenport anything I can do to move this along? |
JesusMtnez
approved these changes
May 18, 2021
JesusMtnez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Doobie documentation on Meta,
This commit separates the constraints for the
FUUIDMetainstance, adding a new implicit definition and deprecating the old one.