Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic YAML language service implementation #50

Merged
merged 11 commits into from
Jul 2, 2022

Conversation

davelopez
Copy link
Owner

Groundwork towards #49

This implements a basic YAML language service (logic to deal with raw YAML format) based on Red Hat's yaml-language-server embedded service. But keeping only the minimum necessary logic and reimplementing some of the parts to simplify them.

  • Adds an error-tolerant YAML parser that converts the YML Abstract Syntax Tree to the existing JSON AST so we can share the same logic between the 2 language servers for exploring the syntax tree of the documents.
  • Adds basic YAML syntax error validation.
  • YAML auto-formatting (without prettier dependency).

This PR also includes various refactorings to better reuse code between the 2 language servers and around testing.

@davelopez davelopez added the enhancement New feature or request label Jun 26, 2022
@davelopez davelopez mentioned this pull request Jun 26, 2022
3 tasks
@davelopez davelopez merged commit 05ed58d into main Jul 2, 2022
@davelopez davelopez deleted the basic_yaml_language_service branch July 2, 2022 17:15
@davelopez davelopez added this to the v0.3.0 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant