Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Validation Rule: workflow_outputs must have a label #44

Merged
merged 9 commits into from
Jun 6, 2022

Conversation

davelopez
Copy link
Owner

Closes #41

Includes some unit tests and schema updates.

This custom rule can be added simply by using setValidationRules:

this.languageService.setValidationRules([new WorkflowOutputLabelValidation()]);

The idea is to include this rule as part of one of the future validation profiles (#27).

workflow_output_label_rule

davelopez added 9 commits June 5, 2022 14:46
To display the same kind of message as the schema validator for missing properties.
This providers just loads the appropriate workflow document in an object with some documentation.
- Move UUID to definition.
- Define some properties for `workflow_outputs`
For testing WorkflowOutputLabelValidation
@davelopez davelopez added the enhancement New feature or request label Jun 5, 2022
@davelopez davelopez merged commit ef46fab into main Jun 6, 2022
@davelopez davelopez deleted the add_output_labels_rule branch June 6, 2022 10:12
@davelopez davelopez added this to the v0.2.0 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that all workflow outputs have labels.
1 participant