Fix clean workflow #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps during debugging
The `extensionDevelopmentPath` was not pointing to the right directory where the extension manifest file was in.
Was failing because conflicting edits trying to remove the trailing comma for a property that was already removed. Now, if the property with the trailing comma is removed, it will check the previous property and so on.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
When removing a property that is the last one and then trying to remove the trailing comma of the previous property, it might happen that the previous property was also a 'non-essential' property and was removed too... this creates conflicting edits in the document and the command was canceled...
Includes an integration test for the Clean workflow command and some enhancements and fixes around integration tests.