Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for spurious failures of resilver_restart_001 test #1

Closed
wants to merge 168 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
168 commits
Select commit Hold shift + click to select a range
e60e158
Add subcommand to wait for background zfs activity to complete
jgallag88 Sep 14, 2019
2a0d418
Scrubbing root pools may deadlock on kernels without elevator_change(…
loli10K Sep 14, 2019
637f0c6
Fix clone handling with encryption roots
Sep 16, 2019
7e15647
ZTS: Fix /usr/bin/env: 'python2': No such file or directory
loli10K Sep 16, 2019
b24771a
Prevent gcc -Werror=maybe-uninitialized warnings in spa_wait_common()
loli10K Sep 16, 2019
fcd37b6
Device removal of indirect vdev panics the kernel
loli10K Sep 16, 2019
dd262c9
Fix dsl_scan_ds_clone_swapped logic
avg-I Sep 18, 2019
afc8f0a
Refactor libzfs_error_init newlines
Sep 18, 2019
d49d733
Disabled resilver_defer feature leads to looping resilvers
KodyKantor Sep 22, 2019
73d7820
Use signed types to prevent subtraction overflow
Sep 22, 2019
d359e99
diff_cb() does not handle large dnodes
loli10K Sep 24, 2019
5df7e9d
OpenZFS restructuring - zvol
mattmacy Sep 25, 2019
f81d5ef
Add warning for zfs_vdev_elevator option removal
behlendorf Sep 25, 2019
5e5cefb
ZTS: harden xattr/cleanup.ksh
behlendorf Sep 25, 2019
479d7d3
ZTS: Fix typos in zfs_destroy tests cleanup
Sep 25, 2019
bb61cc3
Fix encryption hierarchy issues with zfs recv -d
Sep 26, 2019
3768db2
Adding slack notifier
bmcgough Sep 26, 2019
7bb0c29
OpenZFS restructuring - zfs_ioctl
mattmacy Sep 27, 2019
3283f13
OpenZFS restructuring - zpool
mattmacy Sep 30, 2019
99573cc
Timeout waiting for ZVOL device to be created
Oct 1, 2019
608f874
Perform KABI checks in parallel
behlendorf Oct 1, 2019
bd76e68
Fix for zfs-dracut regression
dacianstremtan Oct 1, 2019
7111c86
Enable clang to use intrinsics for lz4
mattmacy Oct 1, 2019
13a4027
OpenZFS restructuring - arc_stats
mattmacy Oct 1, 2019
6360e27
Add inode accessors to common code
mattmacy Oct 2, 2019
d31277a
OpenZFS restructuring - libspl
mattmacy Oct 2, 2019
8ae8b2a
Workaround to avoid a race when /var/lib is a persistent dataset
didrocks Oct 2, 2019
e1c216f
ZTS: Fix upgrade_readonly_pool
behlendorf Oct 3, 2019
7c5eff9
OpenZFS restructuring - libzutil
mattmacy Oct 3, 2019
73cdcc6
OpenZFS restructuring - libzfs
mattmacy Oct 3, 2019
64b6c47
dbuf_hold_impl() cleanup to improve cached read performance
tonynguien Oct 3, 2019
2cc479d
Rename rangelock_ functions to zfs_rangelock_
mattmacy Oct 3, 2019
6bd4f45
Fix automount for root filesystems
behlendorf Oct 4, 2019
94bcf6f
ZTS: Fix trim/trim_config and trim/autotrim_config
behlendorf Oct 4, 2019
7b50929
module/Makefile.in: don't run xargs if empty
gmelikov Oct 8, 2019
d0a84ba
ZTS: Fix mmp_hostid test
ikozhukhov Oct 8, 2019
ca57777
Reduce loaded range tree memory usage
pcd1193182 Oct 9, 2019
5e74ac5
Move platform independent tests to a shared runfile
Oct 9, 2019
381d91d
Sort list of generated files in configure.ac
Oct 9, 2019
c5858ff
Make clang happy with vdev_raidz_ code
mattmacy Oct 10, 2019
e4f5fa1
Fix strdup conflict on other platforms
mattmacy Oct 10, 2019
f3dc4a8
Update `zfs program` command usage
behlendorf Oct 10, 2019
eedb3a6
Make `zil_async_to_sync` visible to platform code
mattmacy Oct 10, 2019
6501906
Add kmem cache accessors
mattmacy Oct 10, 2019
2516a87
Move get_temporary_prop to platform code
mattmacy Oct 10, 2019
715c996
Fix pool creation with feature@allocation_classes disabled
loli10K Oct 10, 2019
767f65c
Fix some style nits in tests
Oct 11, 2019
d96635a
Clarify loop variable name in zfs copies test
Oct 11, 2019
8038842
Implement ZPOOL_IMPORT_UDEV_TIMEOUT_MS
ryao Oct 9, 2019
af1698f
Expose dmu_buf_hold_array_by_dnode to platform code
mattmacy Oct 11, 2019
bce795a
Remove linux/mod_compat.h from common code
mattmacy Oct 11, 2019
516a83f
Function name and comment updates
pcd1193182 Oct 11, 2019
ea25ed2
ZTS: Fix zpool_status_-s
behlendorf Oct 11, 2019
2c6fa6e
Typo fix in comment: dso_dryrun
chrisrd Oct 11, 2019
d292307
Modify sharenfs=on default behavior
behlendorf Oct 14, 2019
c324701
Move zio_delay_interrupt to platform code
mattmacy Oct 14, 2019
cdbba10
Move zfs_onexit_fd_hold to platform code
mattmacy Oct 14, 2019
511fce6
Don't call sizeof on void
pcd1193182 Oct 14, 2019
177c79d
Remove dead code and cleanup scoping in dmu_send.c
mattmacy Oct 14, 2019
47d57db
Fix signature for private functions without header declarations
mattmacy Oct 17, 2019
cf2eba6
Add default case to lua kernel code
mattmacy Oct 17, 2019
0e939e4
Move linux specific mmp module_param_call handler to platform code
mattmacy Oct 17, 2019
08f530c
Make zfsdev_getminor signature cross platform
mattmacy Oct 17, 2019
4313a5b
Detect if sed supports --in-place
Oct 17, 2019
c9c9c1e
OpenZFS restructuring - ARC memory pressure
mattmacy Oct 18, 2019
851eda3
Update skc_obj_alloc for spl kmem caches that are backed by Linux
sdimitro Oct 18, 2019
9f3c72a
Name anonymous enum of KMC_BIT constants
sdimitro Oct 18, 2019
4063440
ZTS: Written props test fails with 4k disks
jwk404 Oct 18, 2019
8b2d097
Remove gratuitous Linux only include in ztest & zdb
mattmacy Oct 20, 2019
685abd5
Use correct format string when printing int8
mattmacy Oct 21, 2019
64b2e7d
Use platform independent error code for libzfs_run_process_impl
mattmacy Oct 23, 2019
05d07ba
Don't call arc_buf_destroy on unallocated arc_buf
chrisrd Oct 23, 2019
b834b58
Use zfs_ioctl with zfs_cmd_t in libzfs
mattmacy Oct 24, 2019
10fa254
Linux 4.14, 4.19, 5.0+ compat: SIMD save/restore
behlendorf Oct 24, 2019
4c6225b
ZTS: Consistency pass for .ksh extensions
Oct 24, 2019
28f7427
ZTS: Move tmpfile tests to linux.run
Oct 24, 2019
b423832
Fix incremental recursive encrypted receive
Oct 24, 2019
68a1b15
Remove sdt.h
mattmacy Oct 25, 2019
1952fe0
Move platform dependent errno aliases
mattmacy Oct 25, 2019
c392c5a
Move final zvol_remove_minors to common code
mattmacy Oct 25, 2019
0ee89a1
Remove non-portable pointer is valid assert
mattmacy Oct 25, 2019
24cf9f4
Use zfs_ioctl() in zinject.c
mattmacy Oct 25, 2019
5f3eceb
Remove unused headers from uu_string.c
mattmacy Oct 25, 2019
fdf5593
ZTS: Move more tests to linux.run
Oct 26, 2019
9e2ca0b
Fix header guard typo
mattmacy Oct 26, 2019
6963414
Remove unneeded header from libzpool/kernel.c
mattmacy Oct 26, 2019
e357046
Fix for ARC sysctls ignored at runtime
loli10K Oct 26, 2019
7125a10
Fix zpool history unbounded memory usage
davidchenntnx Oct 28, 2019
4a22ba5
Minor spa portability fixes
mattmacy Oct 28, 2019
d46f0de
Add wrapper for Linux BLKFLSBUF ioctl
mattmacy Oct 28, 2019
bae11ba
Fix 'zfs change-key' with unencrypted child
Oct 30, 2019
0b2a642
Add AVX512BW variant of fletcher
rdolbeau Oct 30, 2019
f63e2fe
Fix contrib/zcp/Makefile.am
behlendorf Oct 30, 2019
936e2d6
dracut/zfs-load-key.sh: properly remove prefixes
alaviss Oct 30, 2019
2a3aa5a
Factor Linux specific code out of spa_misc.c
mattmacy Oct 31, 2019
59055a0
Include prototypes for vdev_initialize
mattmacy Oct 31, 2019
a5308e2
Don't cast away const
mattmacy Oct 31, 2019
ab44be1
ZTS: Fix removal_with_errors
behlendorf Oct 31, 2019
c4ae27c
Move sha2.h to platform code
mattmacy Oct 31, 2019
156f74f
Return an error code from zfs_acl_chmod_setattr
mattmacy Nov 1, 2019
32682b0
Fix icp build on FreeBSD
mattmacy Nov 1, 2019
bbc18de
Remove ECKSUM alias in zinject
mattmacy Nov 1, 2019
bd4dde8
Prefix struct rangelock
mattmacy Nov 1, 2019
4a2ed90
Wrap Linux module macros
mattmacy Nov 1, 2019
e5d1c27
Enable use of DTRACE_PROBE* macros in "spl" module
Oct 30, 2019
ae38e00
Add tracepoints for taskq entry lifetime events
Oct 24, 2019
1c47c2c
zvol_wait should ignore redacted zvols
pzakha Nov 6, 2019
27ece2e
Move platform specific parts of zfs_znode.h to platform code
mattmacy Nov 6, 2019
4254e40
Preliminary support for RV64G
rdolbeau Nov 6, 2019
734de7c
Add a notice in /etc/defaults/zfs for systemd users
cdluminate Nov 6, 2019
6c7023a
Skip loading already loaded key
vozhyk- Nov 8, 2019
2f1ca8a
Isolate code specific to Linux in cmd/
Nov 11, 2019
f15d6a5
Improve logging of 128KB writes
amotin Nov 11, 2019
5a6ac4c
Remove zpl_revalidate
snajpa Nov 11, 2019
035ebb3
Allow platform dependent path stripping for vdevs
Nov 11, 2019
066e825
Linux compat: Minimum kernel version 3.10
behlendorf Nov 12, 2019
1f2f46b
Add wrapper stub for zfs_cmd ioctl to libzpool
mattmacy Nov 12, 2019
870fc32
Reorganize zfs(8) man page into sections
overhacked Nov 12, 2019
c5ebfbb
Reorganize zpool(8) man page into sections
overhacked Nov 13, 2019
94a570e
Fix `zpool create -o <property>` error message
behlendorf Nov 13, 2019
c025008
Add missing documentation for some KMC flags
c0d3z3r0 Jul 21, 2019
6695588
Make use of kvmalloc if available and fix vmem_alloc implementation
c0d3z3r0 Jul 21, 2019
6d948c3
Add kmem_cache flag for forcing kvmalloc
c0d3z3r0 Jul 21, 2019
8aaa10a
Check for __GFP_RECLAIM instead of GFP_KERNEL
c0d3z3r0 Aug 6, 2019
7ba964c
Prevent NULL pointer dereference in blkg_tryget() on EL8 kernels
loli10K Nov 13, 2019
64c77c4
Change zed.service to zfs-zed.service in man page
Nov 13, 2019
cc1a1e1
Remove inappropiate error message suggesting to use '-r'
InsanePrawn Nov 15, 2019
41e1aa2
Break out of zfs_zget early if unlinked znode
hrasiq Nov 15, 2019
7ae3f8d
Partially revert 5a6ac4c
behlendorf Nov 18, 2019
8221bcf
Remove requirement for -d 1 for zfs list and zfs get with bookmarks
InsanePrawn Nov 19, 2019
540312d
ZTS: Casenorm fix unicode interpretation
gmelikov Nov 20, 2019
67a6c3b
ZTS: tst.terminate_by_signal increase test threshold
behlendorf Nov 21, 2019
da92d5c
Add zfs_file_* interface, remove vnodes
mattmacy Nov 21, 2019
0c46813
Check for unlinked znodes after igrab()
mfoliveira Nov 21, 2019
894f669
Add display of checksums to zdb -R
PaulZ-98 Nov 27, 2019
3c819a2
Prevent unnecessary resilver restarts
jwpoduska Nov 27, 2019
9e17e6f
Remove zfs_vdev_elevator module option
behlendorf Nov 27, 2019
7c1bf0c
Implement -A (ignore ASSERTs) for zdb
PaulZ-98 Nov 27, 2019
d8ce455
Fix small typo in systemd mount generator
InsanePrawn Nov 22, 2019
70d2dd9
Fix non-absolute path in systemd mount generator
InsanePrawn Nov 23, 2019
c940bf0
Fix encryption logic in systemd mount generator
InsanePrawn Nov 22, 2019
d6f67df
Minor diff reduction with ZoF in include/sys
mattmacy Nov 27, 2019
a7c3588
ZTS: Fix attach-o_ashift.ksh for multiple platforms
ikozhukhov Nov 27, 2019
a5b762a
Resolve ZoF differences in zfs_ioctl.h
mattmacy Nov 30, 2019
77323bc
Add FreeBSD support to zio_crypto.h
mattmacy Nov 30, 2019
f348c78
Mark Linux fallocate extensions as specific to Linux
mattmacy Nov 30, 2019
c54687c
Make asm-x86_64/atomic.S build on FreeBSD
mattmacy Nov 30, 2019
101f9b1
Add FreeBSD code to arc_summary and arcstat
Nov 30, 2019
758699b
Restructure nvlist_nv_alloc to work on FreeBSD
mattmacy Nov 30, 2019
42a826e
Add FreeBSD required defines to mntent.h
mattmacy Nov 30, 2019
5142032
Move zfs_cmd_t copyin/copyout to platform code
mattmacy Dec 2, 2019
e69bb31
Adapt gitignore for modules
c0d3z3r0 Dec 2, 2019
74d1d74
Move linux qsort def to platform header
mattmacy Dec 3, 2019
bff8fb3
Mark write_record static
mattmacy Dec 3, 2019
b367334
Wrap module_param_call() routines under __linux__
mattmacy Dec 3, 2019
624222a
Increase allowed 'special_small_blocks' maximum value
behlendorf Dec 3, 2019
5ff2249
Fix use-after-free in case of L2ARC prefetch failure
amotin Dec 3, 2019
7af7286
Codecov tweaks
Dec 3, 2019
54c8366
ICP: Fix null pointer dereference and use after free
AttilaFueloep Dec 3, 2019
5a08977
Fix zdb_read_block using zio after it is destroyed
PaulZ-98 Dec 3, 2019
618b6ad
Refactor compression algorithm selection for tests
Dec 4, 2019
be627fc
Refactor zfs_context.h to build on FreeBSD
mattmacy Dec 4, 2019
12395c7
Fix reporting of L2ARC hits/misses in arc_summary3
gamanakis Dec 4, 2019
2a8ba60
Replace ASSERTV macro with compiler annotation
mattmacy Dec 5, 2019
e64e84e
Refactor deadman set failmode to be cross platform
mattmacy Dec 5, 2019
054a049
Add ZFS_IOC offsets for FreeBSD
mattmacy Dec 5, 2019
f95704c
Disable EDONR on FreeBSD
mattmacy Dec 5, 2019
8fcd29b
Fixes for spurious failures of resilver_restart_001 test
jwpoduska Dec 6, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor zfs_context.h to build on FreeBSD
- on Linux move Linux specific headers to zfs_context_os.h
- on FreeBSD move FreeBSD specific definitions to zfs_context_os.h
- remove duplicate tsd_ definitions
- remove unused AT_TYPE

Reviewed-by: Jorgen Lundman <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Don Brady <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes openzfs#9668
mattmacy authored and behlendorf committed Dec 4, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit be627fc84711d2382d179392e3313f9fda8d24a3
1 change: 1 addition & 0 deletions include/os/linux/zfs/sys/Makefile.am
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@ KERNEL_H = \
$(top_srcdir)/include/os/linux/zfs/sys/trace_zil.h \
$(top_srcdir)/include/os/linux/zfs/sys/trace_zio.h \
$(top_srcdir)/include/os/linux/zfs/sys/trace_zrlock.h \
$(top_srcdir)/include/os/linux/zfs/sys/zfs_context_os.h \
$(top_srcdir)/include/os/linux/zfs/sys/zfs_ctldir.h \
$(top_srcdir)/include/os/linux/zfs/sys/zfs_dir.h \
$(top_srcdir)/include/os/linux/zfs/sys/zfs_vfsops.h \
Original file line number Diff line number Diff line change
@@ -19,12 +19,12 @@
*
* CDDL HEADER END
*/
/*
* Copyright 2006 Sun Microsystems, Inc. All rights reserved.
* Use is subject to license terms.
*/

#ifndef _LIBSPL_SYS_BITMAP_H
#define _LIBSPL_SYS_BITMAP_H
#ifndef ZFS_CONTEXT_OS_H
#define ZFS_CONTEXT_OS_H

#include <sys/uio_impl.h>
#include <linux/dcache_compat.h>
#include <linux/utsname_compat.h>

#endif
22 changes: 4 additions & 18 deletions include/sys/zfs_context.h
Original file line number Diff line number Diff line change
@@ -29,7 +29,6 @@
#define _SYS_ZFS_CONTEXT_H

#ifdef __KERNEL__

#include <sys/note.h>
#include <sys/types.h>
#include <sys/atomic.h>
@@ -48,7 +47,6 @@
#include <sys/strings.h>
#include <sys/byteorder.h>
#include <sys/list.h>
#include <sys/uio_impl.h>
#include <sys/time.h>
#include <sys/zone.h>
#include <sys/kstat.h>
@@ -61,11 +59,8 @@
#include <sys/disp.h>
#include <sys/trace.h>
#include <sys/procfs_list.h>
#include <linux/dcache_compat.h>
#include <linux/utsname_compat.h>
#include <sys/mod.h>
#include <sys/sysmacros.h>

#include <sys/zfs_context_os.h>
#else /* _KERNEL */

#define _SYS_MUTEX_H
@@ -88,7 +83,6 @@
#include <pthread.h>
#include <setjmp.h>
#include <assert.h>
#include <alloca.h>
#include <umem.h>
#include <limits.h>
#include <atomic.h>
@@ -101,7 +95,6 @@
#include <sys/types.h>
#include <sys/cred.h>
#include <sys/sysmacros.h>
#include <sys/bitmap.h>
#include <sys/resource.h>
#include <sys/byteorder.h>
#include <sys/list.h>
@@ -117,6 +110,8 @@
#include <sys/utsname.h>
#include <sys/trace_zfs.h>

#include <sys/zfs_context_os.h>

/*
* Stack
*/
@@ -333,15 +328,7 @@ extern void cv_broadcast(kcondvar_t *cv);
*/
#define tsd_get(k) pthread_getspecific(k)
#define tsd_set(k, v) pthread_setspecific(k, v)
#define tsd_create(kp, d) pthread_key_create(kp, d)
#define tsd_destroy(kp) /* nothing */

/*
* Thread-specific data
*/
#define tsd_get(k) pthread_getspecific(k)
#define tsd_set(k, v) pthread_setspecific(k, v)
#define tsd_create(kp, d) pthread_key_create(kp, d)
#define tsd_create(kp, d) pthread_key_create((pthread_key_t *)kp, d)
#define tsd_destroy(kp) /* nothing */

/*
@@ -562,7 +549,6 @@ typedef struct vsecattr {
size_t vsa_aclentsz; /* ACE size in bytes of vsa_aclentp */
} vsecattr_t;

#define AT_TYPE 0x00001
#define AT_MODE 0x00002
#define AT_UID 0x00004
#define AT_GID 0x00008
3 changes: 2 additions & 1 deletion lib/libspl/include/os/linux/sys/Makefile.am
Original file line number Diff line number Diff line change
@@ -7,4 +7,5 @@ libspl_HEADERS = \
$(top_srcdir)/lib/libspl/include/os/linux/sys/param.h \
$(top_srcdir)/lib/libspl/include/os/linux/sys/stat.h \
$(top_srcdir)/lib/libspl/include/os/linux/sys/sysmacros.h \
$(top_srcdir)/lib/libspl/include/os/linux/sys/uio.h
$(top_srcdir)/lib/libspl/include/os/linux/sys/uio.h \
$(top_srcdir)/lib/libspl/include/os/linux/sys/zfs_context_os.h
25 changes: 25 additions & 0 deletions lib/libspl/include/os/linux/sys/zfs_context_os.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* CDDL HEADER START
*
* The contents of this file are subject to the terms of the
* Common Development and Distribution License, Version 1.0 only
* (the "License"). You may not use this file except in compliance
* with the License.
*
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
* or http://www.opensolaris.org/os/licensing.
* See the License for the specific language governing permissions
* and limitations under the License.
*
* When distributing Covered Code, include this CDDL HEADER in each
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
* If applicable, add the following below this CDDL HEADER, with the
* fields enclosed by brackets "[]" replaced with your own identifying
* information: Portions Copyright [yyyy] [name of copyright owner]
*
* CDDL HEADER END
*/

#ifndef ZFS_CONTEXT_OS_H
#define ZFS_CONTEXT_OS_H
#endif
1 change: 0 additions & 1 deletion lib/libspl/include/sys/Makefile.am
Original file line number Diff line number Diff line change
@@ -4,7 +4,6 @@ libspldir = $(includedir)/libspl/sys
libspl_HEADERS = \
$(top_srcdir)/lib/libspl/include/sys/acl.h \
$(top_srcdir)/lib/libspl/include/sys/acl_impl.h \
$(top_srcdir)/lib/libspl/include/sys/bitmap.h \
$(top_srcdir)/lib/libspl/include/sys/callb.h \
$(top_srcdir)/lib/libspl/include/sys/cmn_err.h \
$(top_srcdir)/lib/libspl/include/sys/cred.h \