Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remark-wiki-link][m]: Add image size adjustment in remark-wiki-link #1084

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

mohamedsalem401
Copy link
Contributor

For datopian/flowershow#592

We add width and height to img tags, and also we add inline styling for the width and the height of the image.

Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: af0b4de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@portaljs/remark-wiki-link Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
portaljs-alan-turing ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am
portaljs-ckan ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am
portaljs-ckan-ssg ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am
portaljs-fivethirtyeight ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am
portaljs-git-example ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am
portaljs-learn ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am
portaljs-openspending ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am
portaljs-storybook ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am
site-portaljs ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2024 11:45am

Copy link
Member

@olayway olayway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Just some minor changes for improved readability and efficiency, and an additional test for when only one dimension is specified.

Also, next time, please make sure to reduce noise by not including any redundant formatting changes, as this is extremely hard to read.

packages/remark-wiki-link/src/lib/fromMarkdown.ts Outdated Show resolved Hide resolved
packages/remark-wiki-link/src/lib/html.ts Outdated Show resolved Hide resolved
@olayway
Copy link
Member

olayway commented Feb 1, 2024

@mohamedsalem401 Please remember to add a changeset file :)

@rufuspollock
Copy link
Member

@mohamedsalem401 can you do quick tweaks so we can get this merged.

@mohamedsalem401
Copy link
Contributor Author

@rufuspollock
Sure, I will work on this on Monday.

@mohamedsalem401
Copy link
Contributor Author

@rufuspollock @olayway
I updated the PR.

  • Added test case for single dimension [[image.png|100]]
  • Applied the refactoring suggestions
  • Updated tests
  • Added changeset

All tests are running correctly.

@olayway olayway self-requested a review April 15, 2024 16:34
@mohamedsalem401 mohamedsalem401 merged commit 57952e0 into main Apr 15, 2024
10 checks passed
@mohamedsalem401 mohamedsalem401 deleted the image-size branch April 15, 2024 16:39
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants