-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[remark-wiki-link][m]: Add image size adjustment in remark-wiki-link
#1084
Conversation
🦋 Changeset detectedLatest commit: af0b4de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 9 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Just some minor changes for improved readability and efficiency, and an additional test for when only one dimension is specified.
Also, next time, please make sure to reduce noise by not including any redundant formatting changes, as this is extremely hard to read.
packages/remark-wiki-link/test/micromarkExtensionWikiLink.spec.ts
Outdated
Show resolved
Hide resolved
@mohamedsalem401 Please remember to add a changeset file :) |
@mohamedsalem401 can you do quick tweaks so we can get this merged. |
@rufuspollock |
@rufuspollock @olayway
All tests are running correctly. |
For datopian/flowershow#592
We add
width
andheight
toimg
tags, and also we add inline styling for the width and the height of the image.