Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flatui #1011

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Fix flatui #1011

merged 2 commits into from
Aug 15, 2023

Conversation

luccasmmg
Copy link
Member

Fixes #943

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2023

🦋 Changeset detected

Latest commit: 8e89613

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@portaljs/components Patch
@portaljs/ckan Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portaljs-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 7:49pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
portaljs-alan-turing ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2023 7:49pm
portaljs-ckan ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2023 7:49pm
portaljs-ckan-ssg ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2023 7:49pm
portaljs-fivethirtyeight ⬜️ Ignored (Inspect) Aug 14, 2023 7:49pm
portaljs-git-example ⬜️ Ignored (Inspect) Aug 14, 2023 7:49pm
portaljs-learn ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2023 7:49pm
portaljs-openspending ⬜️ Ignored (Inspect) Aug 14, 2023 7:49pm
site-portaljs ⬜️ Ignored (Inspect) Visit Preview Aug 14, 2023 7:49pm

Copy link
Member

@demenech demenech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and I couldn't reproduce the initial bug anymore but I noticed that the tables didn't seem to be loading concurrently, and after this update they were. Also definitely aligned to the docs https://tanstack.com/query/v4/docs/react/guides/query-keys#if-your-query-function-depends-on-a-variable-include-it-in-your-query-key

@demenech demenech merged commit 8c5c6a2 into main Aug 15, 2023
@demenech demenech deleted the fix-flatui branch August 15, 2023 18:00
This was referenced Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: <FlatUiTable /> doesn't work properly when using rawCsv=...
2 participants