Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components][iFrame] Change default height #1170

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

lucasmbispo
Copy link
Member

No description provided.

@lucasmbispo lucasmbispo requested a review from demenech June 4, 2024 12:27
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
portaljs-alan-turing ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am
portaljs-ckan ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am
portaljs-ckan-ssg ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am
portaljs-fivethirtyeight ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am
portaljs-git-example ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am
portaljs-learn ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am
portaljs-openspending ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am
portaljs-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am
site-portaljs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 0:40am

Copy link

changeset-bot bot commented Jun 4, 2024

🦋 Changeset detected

Latest commit: 9690115

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@portaljs/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@demenech demenech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a major release. I'd make it a patch.

@lucasmbispo
Copy link
Member Author

This shouldn't be a major release. I'd make it a patch.

Done

@demenech demenech merged commit 5deabac into main Jun 4, 2024
10 checks passed
@demenech demenech deleted the fix/iframe-height branch June 4, 2024 17:57
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants