Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib(completions): update completions for qsv v0.134.0 and fix subcommand options #2135

Merged
merged 2 commits into from
Sep 12, 2024
Merged

contrib(completions): update completions for qsv v0.134.0 and fix subcommand options #2135

merged 2 commits into from
Sep 12, 2024

Conversation

rzmk
Copy link
Collaborator

@rzmk rzmk commented Sep 12, 2024

image

  • Fix: add missing completions for some commands
  • Fixes options completions not showing when using qsv commands that have subcommands (pressing tab after the subcommand should show the "global" qsv command's arguments now).

Before:

image

After:

image

@jqnatividad jqnatividad merged commit 410ee69 into master Sep 12, 2024
2 checks passed
@jqnatividad
Copy link
Collaborator

Thanks @rzmk for staying on top of the completions!

@rzmk rzmk deleted the v0.134.0-completions branch September 12, 2024 14:21
@BrewTestBot BrewTestBot mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzmk @jqnatividad