Skip to content

Commit

Permalink
tests: enable macOS indexed reverse tests
Browse files Browse the repository at this point in the history
I thought they were false positives when they were actual bugs 😦
  • Loading branch information
jqnatividad committed Jul 27, 2024
1 parent 38f5e74 commit 4a0794b
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tests/test_reverse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ fn prop_reverse_no_headers() {
qcheck(p as fn(CsvData) -> bool);
}

#[cfg(not(target_os = "macos"))]
fn prop_reverse_indexed(name: &str, rows: CsvData, headers: bool) -> bool {
let wrk = Workdir::new(name);
wrk.create_indexed("in.csv", rows.clone());
Expand All @@ -69,20 +68,15 @@ fn prop_reverse_indexed(name: &str, rows: CsvData, headers: bool) -> bool {
rassert_eq!(got, expected)
}

// skip on macOS for now because this fails on GH action runner
// but runs successfully on macOS locally
#[test]
#[cfg(not(target_os = "macos"))]
fn prop_reverse_headers_indexed() {
fn p(rows: CsvData) -> bool {
prop_reverse_indexed("prop_reverse_headers_indexed", rows, true)
}
qcheck(p as fn(CsvData) -> bool);
}

// same as above
#[test]
#[cfg(not(target_os = "macos"))]
fn prop_reverse_no_headers_indexed() {
fn p(rows: CsvData) -> bool {
prop_reverse_indexed("prop_reverse_no_headers_indexed", rows, false)
Expand Down

0 comments on commit 4a0794b

Please sign in to comment.