Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle Size: not tree shakable, date-fns not peer dependency #14

Open
hamncheez opened this issue Feb 2, 2021 · 1 comment · May be fixed by #15
Open

Bundle Size: not tree shakable, date-fns not peer dependency #14

hamncheez opened this issue Feb 2, 2021 · 1 comment · May be fixed by #15

Comments

@hamncheez
Copy link

When used with date-fns 2.0, the entire package is imported and prevents tree shaking. Can we allow tree shaking within date-fns-upgrade and include date-fns as a peer dependency instead of direct dependency?
marcodejongh added a commit to atlassian-forks/date-fns-upgrade that referenced this issue Apr 9, 2021
@marcodejongh
Fix broken tree shaking for legacy parse
d806432 
Fixes date-fns#14
This was referenced Apr 9, 2021
Closed
Open
@sivanharel
Copy link

I opened a PR to solve this issue:
#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hamncheez @sivanharel