Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzip support in Ambassador #744

Closed
6 tasks
jazoom opened this issue Aug 27, 2018 · 8 comments
Closed
6 tasks

gzip support in Ambassador #744

jazoom opened this issue Aug 27, 2018 · 8 comments
Assignees
Milestone

Comments

@jazoom
Copy link

jazoom commented Aug 27, 2018

The title says it all. I couldn't find any mention of such a thing in your docs.

Checklist

(This is basically the standard Ambassador definition of done.)

  • Agreement on how feature should be configured
  • Feature is coded
  • Feature is documented
  • Automated tests verify feature is functioning
  • Automated tests verify no errors reported at all on happy paths
  • Automated tests verify that whatever common errors we think of are handled gracefully
@richarddli
Copy link
Contributor

Yes see #544 for the architecture work that is in progress to support gzip (and SNI, among others)

@richarddli richarddli changed the title Is it within the scope of Ambassador to gzip responses? gzip support in Ambassador Aug 27, 2018
@krish512
Copy link

Please include Brotli compression as well

@gsagula
Copy link
Contributor

gsagula commented Nov 23, 2018

@richarddli Since I wrote it for Envoy, I can take the compression integration if no one had.

@krish512 Envoy upstream still doesn’t support Brotli, but it could be easily extended when we get the new compression filter done.

@krish512
Copy link

With Ambassador 0.50 RC1 released, how do I use gzip compression?

@gsagula
Copy link
Contributor

gsagula commented Jan 2, 2019

I don't think that compression was included in this release.

@kflynn kflynn added this to the 0.50.2 milestone Jan 30, 2019
@kflynn kflynn removed this from the 0.51 milestone Feb 12, 2019
@RXminuS
Copy link

RXminuS commented Apr 11, 2019

Hey, has this been added to a milestone or is it released yet?

@gsagula gsagula self-assigned this Apr 29, 2019
@gsagula
Copy link
Contributor

gsagula commented Apr 29, 2019

Working on this one.

@kflynn kflynn added this to the parc-güell milestone May 9, 2019
@kflynn
Copy link
Member

kflynn commented May 9, 2019

So for the first item on the checklist, I assume that gzip is a per-listener thing in Envoy? Is it meaningful to configure it per-Mapping?

Assuming that it's not, do we need more than

compression: gzip

in the ambassador Module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants