Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Planning for ADS/IR/V2 work #544

Closed
rhs opened this issue Jun 21, 2018 · 7 comments
Closed

Refactor Planning for ADS/IR/V2 work #544

rhs opened this issue Jun 21, 2018 · 7 comments

Comments

@rhs
Copy link
Contributor

rhs commented Jun 21, 2018

This is the output of a planning meeting with the goal of figuring out how to proceed on the several refactors we would like to make.

Refactors:

  1. IR Refactor
  2. Moving to ADS
  3. V1 to V2 config
  4. Testing

We primarily identified any user requested features we could think of and grouped these into two categories. Features that may significantly inform a given refactor, and features that we don't necessarily expect to inform the refactor, but should function as a litmus test (once the refactor is done, these features should be trivial).

Features:

  • Better diagnostics (informs 1, 4):
    • for service developers
    • for ambassador developers [with no access to the ambassador pod]
    • for ops
    • report out of sync pods
  • Session affinity (litmus for 1)
  • Regex rewriting (litmus for 1)
  • SNI
  • GRPC UX (litmus for 1)
  • Vanity Domain Provisioning
  • TCP Proxy (informs 1)
  • Faster Reconfig (informs 2)
  • Zero Connection Drop (informs 2)
  • Multiple Listeners (litmus for 1)
  • Endpoint Routing (informs 2)
    • fancy LB algorithms
    • per pod health checking
  • Service Discovery Integrations (informs 2)
  • Better health stuff (informs 2)
    • outlier rejection
    • ...
  • Developer Isolation
  • CRDs as UX for existing functionality
  • compression

Next Steps:

  1. make sure this is complete
  2. do a rough prioritization
  3. get user stories for all the features that inform any refactors
@richarddli richarddli changed the title Refactor Planning Refactor Planning for ADS/IR/V2 work Jun 25, 2018
@richarddli
Copy link
Contributor

richarddli commented Jul 31, 2018

Here's the list of things we need to tackle once we support v2:

@krish512
Copy link

I suggest include Brotli compressions as well

@Tapppi
Copy link

Tapppi commented Feb 13, 2019

Any updates on this since 0.50 is GA?

@richarddli
Copy link
Contributor

Work is ongoing @Tapppi but PRs are encouraged! We've gotten to 2 on the list.

@enriched
Copy link

Is gzip support in the works? I see that envoy has a gzip http filter would there be a way to add this to the configuration manually as a workaround?

@richarddli
Copy link
Contributor

@enriched it's straightforward to add now that we have v2 support, and we'd be happy to review the PR (one of our programmers actually wrote that filter). looking for someone in the community to add and test it!

@kflynn
Copy link
Member

kflynn commented May 28, 2019

This is long since done (yow). There's a separate issue for gzip support (#744).

@kflynn kflynn closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants