Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 storage statistics #215

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

siriusyim
Copy link
Member

✅ Closes: #197

Related Issues

close

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • Tests exist for new functionality or change in behavior
  • CI is green

@siriusyim siriusyim added the draft Don't merge,only draft label Jan 25, 2024
@siriusyim siriusyim force-pushed the feat/storage-statistics branch 5 times, most recently from d325bc3 to 705dabd Compare January 26, 2024 04:44
@siriusyim siriusyim removed the draft Don't merge,only draft label Jan 26, 2024
Copy link
Member

@waynewyang waynewyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where call the _addCanceled?
If this part of the logic cannot be handled at the moment, please submit a new issue.
then I'll merge this PR.

@waynewyang waynewyang merged commit 5d3ff69 into main Jan 26, 2024
4 checks passed
@waynewyang waynewyang deleted the feat/storage-statistics branch January 26, 2024 05:47
@siriusyim
Copy link
Member Author

where call the _addCanceled? If this part of the logic cannot be handled at the moment, please submit a new issue. then I'll merge this PR.

ref #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The storage includes statistics for Count/Size/StorageInfo
2 participants