Remove outdated Python pre-3.7 references #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absurdfarce
approved these changes
Nov 13, 2023
| @@ -176,7 +176,7 @@ Use tee to capture logs and see them on your terminal:: | |||
|
|
|||
| Testing Multiple Python Versions | |||
| -------------------------------- | |||
| If you want to test all of python 2.7, 3.5, 3.6, 3.7, and pypy, use tox (this is what | |||
| If you want to test all of python 3.7, 3.8, and pypy, use tox (this is what | |||
There was a problem hiding this comment.
Nice find! I must've missed this one when I put out the last release 🤦
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| if not hasattr(ssl, 'match_hostname'): | |||
| try: | |||
| from backports.ssl_match_hostname import match_hostname | |||
| from ssl import match_hostname | |||
There was a problem hiding this comment.
This seems like exactly the right idea.
I'll also note that ssl.match_hostname has been deprecated since Python 3.7 and is actually removed in 3.12 (more on that in PYTHON-1331) so these changes will likely be subsequently changed based on whatever happens with that ticket (which is next in my queue). I very much like the other changes in this PR, though, so my inclination is to merge this now and just lay any fixes for PYTHON-1331 on top of this in their own PR.
|
Jenkins build looks good (test failures were all expected given current conditions) |
fruch
added a commit
to fruch/python-driver
that referenced
this pull request
Jun 6, 2024
…sync_with_upstream_3.29.1 version 3.29.0 * tag '3.29.0' of https://github.com/datastax/python-driver: Documentation (and other) updates for 3.29.0 (datastax#1194) PYTHON-1331 ssl.match_hostname() is deprecated in 3.7 (datastax#1191) PYTHON-1371 Add explicit exception type for serialization failures (datastax#1193) Remove outdated Python pre-3.7 references (datastax#1186) PYTHON-1368 Avoid installing DSE deps + executing DSE tests for Python 3.12 (datastax#1188) PYTHON-1366 Handle removal of asyncore in Python 3.12 (datastax#1187) Removed backup(.bak) files (datastax#1185) docs: Fix typo in add_callbacks (datastax#1177) Remove some remnants of Python2 (datastax#1172) PYTHON-1313 Fix asyncio removals in Python 3.10 (datastax#1179) PYTHON-1364 Fix ssl.wrap_socket errors (from eventlet) for Python 3.12 (datastax#1181) Add Jenkins support for Python 3.12.0 (datastax#1180) Update redirects in docs.yaml (datastax#1178) Jenkins using new python versions in the matrix (datastax#1174) Update docs.yaml to point to most recent 3.28.0 docs changes CONN-38 Notes for 3.28.0 on PYTHON-1350 (datastax#1167) Include docs for 3.28.0 Fixed non-valid rst in README
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Jan 5, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Jan 5, 2025
dkropachev
pushed a commit
to scylladb/python-driver
that referenced
this pull request
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.