Skip to content

Commit

Permalink
[fix][admin] Fix NPE in PulsarAdminBuilder when the service is not set (
Browse files Browse the repository at this point in the history
apache#14769)

(cherry picked from commit 0b6b1e2)
(cherry picked from commit e067e00)
  • Loading branch information
RobertIndie authored and nicoloboschi committed Apr 5, 2022
1 parent 60fc086 commit e9dfffb
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package org.apache.pulsar.client.admin.internal;

import static com.google.common.base.Preconditions.checkArgument;
import java.io.IOException;
import java.net.URL;
import java.util.Map;
Expand Down Expand Up @@ -146,6 +147,8 @@ public PulsarAdminImpl(String serviceUrl,
int autoCertRefreshTime,
TimeUnit autoCertRefreshTimeUnit,
ClassLoader clientBuilderClassLoader) throws PulsarClientException {
checkArgument(StringUtils.isNotBlank(serviceUrl), "Service URL needs to be specified");

this.connectTimeout = connectTimeout;
this.connectTimeoutUnit = connectTimeoutUnit;
this.readTimeout = readTimeout;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.pulsar.client.admin.internal;

import static org.testng.Assert.assertEquals;
import static org.testng.Assert.fail;
import org.apache.pulsar.client.admin.PulsarAdmin;
import org.apache.pulsar.client.api.PulsarClientException;
import org.testng.annotations.Test;

public class PulsarAdminBuilderImplTest {

@Test
public void testAdminBuilderWithServiceUrlNotSet() throws PulsarClientException {
try{
PulsarAdmin.builder().build();
fail();
} catch (IllegalArgumentException exception) {
assertEquals("Service URL needs to be specified", exception.getMessage());
}
}
}

0 comments on commit e9dfffb

Please sign in to comment.