Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP-239 - PHP 8 #147

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

PHP-239 - PHP 8 #147

wants to merge 7 commits into from

Conversation

qkdreyer
Copy link

@qkdreyer qkdreyer commented Jan 5, 2022

@qkdreyer qkdreyer changed the title PHP 8 Compatibility with PreparedStatements PHP-239 - PHP 8 Jan 5, 2022
@qkdreyer qkdreyer force-pushed the master branch 23 times, most recently from 44f4db3 to c84ddd3 Compare January 9, 2022 08:10
@qkdreyer qkdreyer force-pushed the master branch 15 times, most recently from b11167c to 48ee3a9 Compare January 10, 2022 08:14
@qkdreyer
Copy link
Author

@mpenick @avalanche123

@qkdreyer
Copy link
Author

@adutra

@adutra
Copy link
Contributor

adutra commented Jan 17, 2022

@absurdfarce would be the right one to look into this.

@CharlemagneLasse
Copy link

CharlemagneLasse commented Oct 20, 2022

With these changes, I get following error when trying to access a row on 8.1:

Uncaught Error: Cannot use object of type Cassandra\\Rows as array

The code is as simple as:

                $res = $session->execute("select * from foobar where key='value'");
                if (!$res->valid())
                        return null;

                $row = $res[0]; // error happens here

Worked fine with PHP 7.4 and the original datastax cassandra driver. So ArrayAccess seems to be broken here.

@qkdreyer
Copy link
Author

I can reproduce... sadly this was not unit tested 😞

@danielhe4rt
Copy link

What is missing exactly? I'm studying about Cassandra and ScyllaDB, since my main lang is PHP it was about to help me a lot on my studies...

@danielhe4rt
Copy link

@qkdreyer how can I get in touch with you? I saw your PHP 8.1 implementations and I'm wondering if there's any chance to use it for a demo.

@Kabingeran
Copy link

Could you update pecl for php 8.x please?

@danielhe4rt
Copy link

I think that its impossible for now since the holders of pecl is from DataStax.

@Kabingeran
Copy link

Kabingeran commented Mar 12, 2023

@danielhe4rt Whose repository is this?

@danielhe4rt
Copy link

Is was a fork from he4rt/ScyllaDB

@danielhe4rt
Copy link

Ping me at discord or twitter!

danielhe4rt#0001
@danielhe4rtless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants