Skip to content

Commit

Permalink
docs: tidy comment for HAVE_FPU (#148)
Browse files Browse the repository at this point in the history
- Replace FIXME with clearer comment. So far this setting is only required when building containerized on MacOS, presumably because mgp123 wants specific instructions for cross-compilation or embedded work. Here it is fine to set this, as the Linux-on-MacOS target platform will definitely have an FPU.
  • Loading branch information
alexallmont committed Nov 20, 2024
1 parent 82b9dd1 commit ff80fc4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/triplets/arm64-linux.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ set(VCPKG_LIBRARY_LINKAGE static)

set(VCPKG_CMAKE_SYSTEM_NAME Linux)

# FIXME for discussion in PR. I had to add this to get containers working in MacOS, as it seems the macro is not set correctly by default.
# HAVE_FPU is on for all native platforms, but not by default when building in a
# Linux container on MacOS (e.g. in devcontainer), so it is set explicitly here.
if (PORT MATCHES "mpg123")
set(VCPKG_CMAKE_CONFIGURE_OPTIONS "-DHAVE_FPU=1")
endif()

0 comments on commit ff80fc4

Please sign in to comment.