Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: treat categorical color column which is also numeric as categorical in parallel coordinates & parallel categories #191

Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat: treat categorical color column which is also numeric as categorical in parallel coordinates & parallel categories #191

merged 2 commits into from
Nov 2, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

@mbelak-dtml mbelak-dtml commented Nov 1, 2023 •
edited
Loading

Previously, categorical color columns (e.g. with values {1,2,3}, such as edvart.example_datasets.dataset_auto()["origin"])
would be treated as numeric in multivariate analysis parallel coordinates & parallel categories sections, i.e. a continuous color scale would be used.

@mbelak-dtml
feat: treat categorical color column which is also numeric as categor…
801543b 
…ical

Previously, categorical color columns (e.g. with values {1,2,3}, such as `edvart.example_datasets.dataset_auto()["origin"]`
would be treated as numeric in multivariate analysis, i.e. a continuous color scale would be used.
@mbelak-dtml mbelak-dtml requested a review from lukany as a code owner November 1, 2023 13:15
@mbelak-dtml mbelak-dtml self-assigned this Nov 1, 2023
lukany
lukany previously approved these changes Nov 2, 2023
View reviewed changes
lukany
lukany requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue is in pairplot.
I would either modify the commit message so that it mentions that it changes the behaviour only for parallel categories/coordinates or change it everytwhere.

image

@mbelak-dtml
Copy link
Collaborator Author

The same issue is in pairplot. I would either modify the commit message so that it mentions that it changes the behaviour only for parallel categories/coordinates or change it everytwhere.

image

The issue is not there -- cylinders is numeric, but treated as categorical. Otherwise there would a continuous color scale, but there is a discrete color scale, which is correct.

@mbelak-dtml mbelak-dtml requested a review from lukany November 2, 2023 08:58
@github-actions github-actions bot dismissed lukany’s stale review November 2, 2023 08:58

Dismissed due to PR edit.

@mbelak-dtml mbelak-dtml changed the title feat: treat categorical color column which is also numeric as categorical feat: treat categorical color column which is also numeric as categorical in parallel coordinates & parallel categories Nov 2, 2023
@lukany lukany enabled auto-merge November 2, 2023 09:39
@lukany lukany added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit 8fa399e Nov 2, 2023
18 checks passed
@lukany lukany deleted the feat/numeric-categorical-color-col branch November 2, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukany lukany lukany approved these changes

Assignees

@mbelak-dtml mbelak-dtml

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbelak-dtml @lukany