fix: fix alignment of colorbar labels for categorical color column in parallel coordinates & parallel categories sections #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbelak-dtml
force-pushed
the
feat/align-categorical-colorbar
branch
from
fba294a to
493fee3
Compare
lukany
requested changes
Nov 2, 2023
There was a problem hiding this comment.
- I would add more details to the commit message as the changelog is generated from commit messages and the current text could be ambiguous. I would mention that it affects parallel coordinates and parallel categories plots in multivariate analysis.
- Not sure if it's
featorfix. Personally it feels more like afixbut leaving it up to you.
mbelak-dtml
changed the title
mbelak-dtml
changed the title
mbelak-dtml
changed the title
Updated the PR title with mention to which plots it affects. Changed to |
lukany
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first and tick labels for categorical columns would previously be aligned to the ends of the colorbar. This PR ensures that the edge tick labels are aligned to the center, same as the non-edge ones are aligned.