fix: fix default number of histogram bins being extremely high #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbelak-dtml
force-pushed
the
fix/histogram-performance-bins
branch
from
8fa6b08 to
c904a1c
Compare
lukany
requested changes
Oct 9, 2023
lukany
approved these changes
Oct 10, 2023
mbelak-dtml
added a commit
that referenced
this pull request
Oct 10, 2023
The high number of bins caused extreme loss of performance for some specific data. For example, for the column `mass (g)` of the `edvart.example_datasets.dataset_meteorite_landings()`, the number of inferred bins is over 5M, even though the dataset contains under 50k rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The high number of bins caused extreme loss of performance for some specific data.
For example, for the column
mass (g)of theedvart.example_datasets.dataset_meteorite_landings(), the number of inferred bins is over 5M, even though the dataset contains under 50k rows.