Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix imports when non-default subsections are specified #151

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

Previously, the subsections enum (which is part of the section class) was not being imported.

Previously, the subsections enum (which is part of the section class) was
not being imported.
@mbelak-dtml mbelak-dtml force-pushed the fix/imports-non-default-subsections branch from 6ad0b37 to 9e8f50f Compare September 26, 2023 13:45
@mbelak-dtml mbelak-dtml marked this pull request as ready for review September 26, 2023 13:47
@mbelak-dtml mbelak-dtml requested a review from lukany September 26, 2023 13:47
@mbelak-dtml mbelak-dtml self-assigned this Sep 26, 2023
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's IMO not nice that code in add_cells and required_imports is so tightly coupled. See #156

@mbelak-dtml mbelak-dtml added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit bae157d Sep 29, 2023
6 checks passed
@mbelak-dtml mbelak-dtml deleted the fix/imports-non-default-subsections branch September 29, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants