refactor!: move static methods outside their respective classes #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the export of a report to notebook much cleaner since tricks with replacing the class name are no longer necessary, which also enables a better implementation of #82. BREAKING CHANGE: All report sections class static methods are moved from their respective classes to module-level functions.
…methods-out-of-classes
lukany
requested changes
Sep 21, 2023
lukany
previously approved these changes
Sep 22, 2023
…methods-out-of-classes
lukany
approved these changes
Sep 22, 2023
mbelak-dtml
added a commit
that referenced
this pull request
Sep 26, 2023
Continuation of #142 for timeseries analysis. BREAKING CHANGE: Renamed top-level functions in `edvart.report_sections.timeseries_analysis`: added prefix `_show` (e.g. `edvart.report_sections.timeseries_analysis.timeseries_analysis` -> `edvart.report_sections.timeseries_analysis.show_timeseries_analysis`)
mbelak-dtml
added a commit
that referenced
this pull request
Sep 26, 2023
Continuation of #142 for timeseries analysis. BREAKING CHANGE: Renamed top-level functions in `edvart.report_sections.timeseries_analysis`: added prefix `_show` (e.g. `edvart.report_sections.timeseries_analysis.timeseries_analysis` -> `edvart.report_sections.timeseries_analysis.show_timeseries_analysis`)
mbelak-dtml
added a commit
that referenced
this pull request
Sep 26, 2023
Continuation of #142 for timeseries analysis. BREAKING CHANGE: Renamed top-level functions in `edvart.report_sections.timeseries_analysis`: added prefix `_show` (e.g. `edvart.report_sections.timeseries_analysis.timeseries_analysis` -> `edvart.report_sections.timeseries_analysis.show_timeseries_analysis`)
mbelak-dtml
added a commit
that referenced
this pull request
Sep 26, 2023
Continuation of #142 for timeseries analysis. BREAKING CHANGE: Renamed top-level functions in `edvart.report_sections.timeseries_analysis`: added prefix `_show` (e.g. `edvart.report_sections.timeseries_analysis.timeseries_analysis` -> `edvart.report_sections.timeseries_analysis.show_timeseries_analysis`)
mbelak-dtml
added a commit
that referenced
this pull request
Sep 26, 2023
Continuation of #142 for timeseries analysis. BREAKING CHANGE: Renamed top-level functions in `edvart.report_sections.timeseries_analysis`: added prefix `_show` (e.g. `edvart.report_sections.timeseries_analysis.timeseries_analysis` -> `edvart.report_sections.timeseries_analysis.show_timeseries_analysis`)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2023
Continuation of #142 for timeseries analysis. BREAKING CHANGE: Renamed top-level functions in `edvart.report_sections.timeseries_analysis`: added prefix `show_` (e.g. `edvart.report_sections.timeseries_analysis.timeseries_analysis` -> `edvart.report_sections.timeseries_analysis.show_timeseries_analysis`)
mbelak-dtml
added a commit
that referenced
this pull request
Oct 2, 2023
Continuation of #142 for timeseries analysis. BREAKING CHANGE: Renamed top-level functions in `edvart.report_sections.timeseries_analysis`: added prefix `_show` (e.g. `edvart.report_sections.timeseries_analysis.timeseries_analysis` -> `edvart.report_sections.timeseries_analysis.show_timeseries_analysis`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the export of a report to notebook much cleaner since tricks with replacing the class name are no longer necessary, which also enables a better implementation of #82.
BREAKING CHANGE: All report sections class static methods are moved from their respective classes to module-level functions. Top-level section functions are also renamed to prevent overriding module names (e.g.
edvart.report_sections.bivariate_analysis.BivariateAnalysis.bivariate_analysis->edvart.report_sections.bivariate_analysis.show_bivariate_analysis).