Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove parameter df from section constructors #141

Merged
merged 2 commits into from
Sep 21, 2023
Merged

refactor!: remove parameter df from section constructors #141

merged 2 commits into from
Sep 21, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

@mbelak-dtml mbelak-dtml commented Sep 20, 2023 •
edited
Loading

BREAKING CHANGE: Parameter df is removed from constructors of GroupAnalysis and UnivariateAnalysis.

@mbelak-dtml mbelak-dtml self-assigned this Sep 20, 2023
@mbelak-dtml mbelak-dtml marked this pull request as ready for review September 20, 2023 11:35
@mbelak-dtml mbelak-dtml requested a review from lukany September 20, 2023 11:35
lukany
lukany requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use refactor! type and add BREAKING CHANGE footer.

@mbelak-dtml mbelak-dtml changed the title feat!: remove parameter df from section constructors refactor!: remove parameter df from section constructors Sep 20, 2023
@mbelak-dtml
Copy link
Collaborator Author

I'd use refactor! type and add BREAKING CHANGE footer.

Changed to refactor! and added the footer.
Now that I think about it, is this still strictly a refactor if the behavior is slightly changed (GroupAnalysis constructor no longer raises when the parameter groupby contains an unknown column -- there is no way to check it now)? 🤔
I would keep it as a refactor anyway though, since it's breaking anyway and it's an edge case.

@mbelak-dtml mbelak-dtml requested a review from lukany September 20, 2023 15:16
@mbelak-dtml mbelak-dtml added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 23883cc Sep 21, 2023
@mbelak-dtml mbelak-dtml deleted the feat/remove-df-param-section-constructors branch September 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukany lukany lukany approved these changes

Assignees

@mbelak-dtml mbelak-dtml

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbelak-dtml @lukany