Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix typo in local variable name #135

Merged
merged 1 commit into from
Sep 20, 2023
Merged

refactor: fix typo in local variable name #135

merged 1 commit into from
Sep 20, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

No description provided.

@mbelak-dtml mbelak-dtml requested a review from lukany September 19, 2023 10:06
@mbelak-dtml mbelak-dtml self-assigned this Sep 19, 2023
lukany
lukany previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but this is IMHO a refactor, not chore. it's a change in code that doesn't affect the functionality

@mbelak-dtml mbelak-dtml changed the title chore: fix typo in local variable name refactor: fix typo in local variable name Sep 19, 2023
@github-actions github-actions bot dismissed lukany’s stale review September 19, 2023 15:01

Dismissed due to PR edit.

@mbelak-dtml
Copy link
Collaborator Author

approved but this is IMHO a refactor, not chore. it's a change in code that doesn't affect the functionality

You're right, changed the title to refactor.

@mbelak-dtml mbelak-dtml requested a review from lukany September 19, 2023 15:01
@lukany lukany added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 4ac77ff Sep 20, 2023
@lukany lukany deleted the chore/fix-typo branch September 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukany lukany lukany approved these changes

Assignees

@mbelak-dtml mbelak-dtml

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbelak-dtml @lukany