feat!: filter and check columns in section main functions #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbelak-dtml
force-pushed
the
feat/filter-columns-in-main-functions
branch
6 times, most recently
from
3548127 to
607956b
Compare
Previously columns were computed in `__init__`s of the respective subsections of multivariate analysis. This required that the DataFrame, on which the analysis is performed, is specified in the constructor, which prevented creating the section without the DataFrame. This change makes #36 much easier and enables removal of the `add_<section>` methods.
mbelak-dtml
force-pushed
the
feat/filter-columns-in-main-functions
branch
from
607956b to
a5f97d4
Compare
lukany
requested changes
Sep 19, 2023
|
Blocked by #139 |
Old behavior: columns [a,b,c] specified -> get pairs [(a,b), (b,a), (a,c), (c,a), (b,c), (c,b)] New behavior: get pairs ([a,b], [a,c], [b,c])
The use of a non-interactive plotting backend prevents plots from being displayed in pop-up windows while running tests. The tests would previously block when a plot was displayed until the user closed it. Resolves #31
Unblocked |
|
@lukany I don't know what I did wrong, but I tried to merge main into this branch, but instead of adding a merge commit I somehow added the new commits from main one by one. |
🤷 |
lukany
previously approved these changes
Sep 20, 2023
Previously columns were computed in `__init__`s of the respective subsections of multivariate analysis. This required that the DataFrame, on which the analysis is performed, is specified in the constructor, which prevented creating the section without the DataFrame. This change makes #36 much easier and enables removal of the `add_<section>` methods.
lukany
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously columns were computed in
__init__s of the respective subsections of multivariate analysis.This required that the DataFrame, on which the analysis is performed, is specified in the constructor, which prevented creating the section without the DataFrame.
This change makes #36 much easier and enables removal of the
add_<section>methods.BREAKING CHANGE: parameter
dfremoved from constructors of:edvart.report_sections.multivariate_analysis.MultivariateAnalysis,edvart.report_sections.multivariate_analysis.PCA,edvart.report_sections.multivariate_analysis.ParallelCoordinates,edvart.report_sections.multivariate_analysis.ParallelCategories,edvart.report_sections.umap.UMAP.BREAKING CHANGE: parameter
nunique_maxremoved from constructors ofedvart.multivariate_analysis.ParallelCategoriesandedvart.multivariate_analysis.ParallelCoordinates. The value is now hard-coded. Specify columns manually to override the default choice of columns, which was influenced by the parameternunique_max.