Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters dataset_name & dataset_description to edvart.ReportBase.export_notebook #59

Closed
mbelak-dtml opened this issue Aug 4, 2023 · 0 comments · Fixed by #60
Closed

Add parameters dataset_name & dataset_description to edvart.ReportBase.export_notebook #59

mbelak-dtml opened this issue Aug 4, 2023 · 0 comments · Fixed by #60
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mbelak-dtml
Copy link
Collaborator

The parameters should behave the same as for the method export_html, i.e. set the title and the description in the exported notebook.
@mbelak-dtml mbelak-dtml added enhancement New feature or request good first issue Good for newcomers labels Aug 4, 2023
@CBROWN-ONS CBROWN-ONS mentioned this issue Aug 5, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 7, 2023
@CBROWN-ONS
feat: Added dataset_name and dataset_description params to export_not…
6e411ad 
…ebook (#60)

Added the ability to pass the `dataset_name` and `dataset_description`
to `edvart.ReportBase.export_notebook`. Uses the parameters in
`edvart.ReportBase._generate_notebook` to write the dataset name and
description to the notebook.
Closes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added dataset_name and dataset_description params to export_notebook
1 participant
@mbelak-dtml