Exclude the 'tests' directory from find_packages in setup.py #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously,
find_packages()
didn'texclude
the tests dir, which would cause pip to install the package under the the nametests
when installing this . (We introduced this change in v1.0 when we switched from specifyingcouncilmatic_core
as the package tofind_packages()
).Exclude the
tests
dir from packaging to preventImportError
s when trying to run tests in dependent packages.Testing instructions
Test this change by testing datamade/django-councilmatic-notifications#33:
cd
todjango-councilmatic-notifications
django-councilmatic-notifications
(with test dependencies) withpip install -e .[tests]
django-councilmatic
, either by running:or
pytest
and confirm tests run normally