Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align seqcli's environment override handling with Seq's #366

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

nblumhardt
Copy link
Member

Fixes #365

The README shows how environment variable setting overrides should work, but this was committed in error, the README updates should have gone to Seq Forwarder, which was the project that gained environment override support at that time.

Instead of fixing the README, I've lined up seqcli's configuration handling with Seq's - this should help us along towards a fully-consistent experience across client and server in the future.

SEQCLI_CONNECTION_SERVERURL now works:

seqcli> SEQCLI_CONNECTION_SERVERURL=https://test.example.com seqcli log -m test 
The command failed: nodename nor servname provided, or not known (test.example.com:443) nodename nor servname provided, or not known
seqcli> seqcli log -m test
The command failed: Connection refused (localhost:5341) Connection refused

Sorry about the confusing experience, @richard-stafflink - my mistake, here :-)

@nblumhardt nblumhardt merged commit dc29e0c into datalust:dev Oct 11, 2024
1 check passed
@richard-stafflink
Copy link

Nice one! thank you for the quick turn-around 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting env var SEQCLI_CONNECTION_SERVERURL doesn't seem to work
3 participants