Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multiple font axes #68

Merged

Conversation

LazyTechwork
Copy link
Contributor

@LazyTechwork LazyTechwork commented Apr 11, 2024

Hello! I use Open Sans variable font in my projects and investigated that google-fonts-helper can't correctly work with them. For example I can't get Open Sans Condensed (wdth axis = 75). I made some refactorings in code to create ability to use several axis.

I'm not sure about 100% compatibility, but all existing tests pass.

About huge diff in src/google-fonts-metadata.ts... I have some gaps in my knowledge of TS, so if there are other ways to add the ability to use other axes in all fonts at the same time, I’d be glad to see!

Resolve #66

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 3.40%. Comparing base (3df2f95) to head (7e2d83d).
Report is 4 commits behind head on main.

Files Patch % Lines
scripts/generate-types.js 0.00% 11 Missing ⚠️
src/construct-url.ts 96.82% 2 Missing ⚠️
src/utils.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #68      +/-   ##
========================================
- Coverage   3.89%   3.40%   -0.49%     
========================================
  Files         11      11              
  Lines      15780   17346    +1566     
  Branches     150     148       -2     
========================================
- Hits         614     590      -24     
- Misses     15164   16754    +1590     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardogobbosouza
Copy link
Member

Thanks @LazyTechwork
Sorry for the delay....
I added other axes in src/google-fonts-metadata.ts

@ricardogobbosouza ricardogobbosouza merged commit 4d24d0d into datalogix:main May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including weight 1000 does not sort correctly, resulting in 404 on Google Fonts.
2 participants