scriv.ini: Provide full relative path to the templates #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe it is due to the change in scriv 1.1.0 — 2023-01-16.
File names specified for file: settings will be interpreted relative
to the current directory if they have path components. If the file name has no
slashes or backslashes, then the old behavior remains: the file will be found
in the fragment directory, or as a built-in template.
yarikoptic
added
release
|
Code Climate has analyzed commit 369dbad and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportBase: 93.92% // Head: 93.92% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 19 19
Lines 889 889
=======================================
Hits 835 835
Misses 54 54 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release attempt failed due to scriv.exceptions.ScrivException: No such file: templates/entry_title.md.j2 .
I believe it is due to the change in scriv 1.1.0 — 2023-01-16.
so let's release with this change