Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the S3 walk-through #1231

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Fixes to the S3 walk-through #1231

merged 7 commits into from
Jul 5, 2024

Conversation

adswa
Copy link
Contributor

@adswa adswa commented Jul 4, 2024

This incorporates the corrected commands and information from #1224.
Fixes #1224.

adswa added 2 commits July 4, 2024 14:14
As amazon s3 depcrecated ACL functionality the usecase and a git annex initremote
parameter relied on, it broke.
Thanks to @NickleDave for the heads-up and the fixes, which should make
it work again given a recent enough git-annex
@adswa
Copy link
Contributor Author

adswa commented Jul 4, 2024

hey @all-contributors please add @NickleDave for bug, content

Copy link
Contributor

@adswa

I've put up a pull request to add @NickleDave! 🎉

Copy link
Collaborator

@mslw mslw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should also mention the publicurl git-annex parameter. Otherwise, I think git-annex would use s3 protocol, and I am not sure if it does it anonymously. See its description in git-annex S3 manpage.

There is, however, a caveat that the git-annex available currently in debian-stable does not recognize the publicurl parameter, and blindly follows public 🙈 I think this is worth another find-out-more. See also this comment.

@adswa
Copy link
Contributor Author

adswa commented Jul 4, 2024

There is, however, a caveat that the git-annex available currently in debian-stable does not recognize the publicurl parameter, and blindly follows public 🙈 I think this is worth another find-out-more. See also #1224 (comment).

I have added a version note to the top of the page, and I also linked the discussion in it.

I believe we should also mention the publicurl git-annex parameter. Otherwise, I think git-annex would use s3 protocol, and I am not sure if it does it anonymously. See its description in git-annex S3 manpage.

Do you mean beyond the description prior to enableremote?

I realize I haven't mentioned the bucket policies - I will read up on what they are and add a findoutmore on them.

@mslw
Copy link
Collaborator

mslw commented Jul 4, 2024

Ah, sorry, publicurl has already been there, I focused on the diff, and the part which removed public -- but at that stage in the chapter we are assuming that everything is private.

So it isn't exactly as bad as what I said (that older annex does not recognize publicurl at all -- it does not recognize it when public=no). You can check again whether the important note at the top is not too strict (because of me), but otherwise I retract my request for changes :-)

@adswa adswa merged commit e2717b0 into main Jul 5, 2024
5 checks passed
@adswa adswa deleted the s3 branch July 5, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with walkthrough for S3 special remote
3 participants