Add UUID check for public DB methods using collectionId before making query #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… query - If the collectionId is not a valid UUID, using `UUID.fromString()` in `execute(Tuple.of(...))` throws an IllegalArgumentException and as a result a failed future, *but the connection is not returned back to the postgres pool* - Hence the pool gets exhausted - So we check if collectionId matches UUID regex before making query - We did not put this check in the OpenAPI spec as it would return a 400 instead of a 400, which may be non-compliant with OGC and STAC specs
code-akki
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UUID.fromString()inexecute(Tuple.of(...))throws an IllegalArgumentException and as a result a failed future, but the connection is not returned back to the postgres pool