Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs-table-schema #36

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Conversation

gopal-mahajan
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ThorodanBrom ThorodanBrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-akki please give your feedback on whether it's OK to use triggers for updates.

According to me, It's not great if one table is using it and the rest aren't. Either all tables need to use it, or none.

src/main/resources/db/migration/V1__Initialise_tables.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/V1__Initialise_tables.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/V1__Initialise_tables.sql Outdated Show resolved Hide resolved
src/main/resources/db/migration/V1__Initialise_tables.sql Outdated Show resolved Hide resolved
@code-akki
Copy link
Collaborator

@gopal-mahajan @ThorodanBrom Yes we can remove the triggers as of now and add it later on as a separate migration as and when required.
@gopal-mahajan Just tp confirm, does created_at and updated_at fields/columns necessary for jobs table?

@gopal-mahajan
Copy link
Collaborator Author

@gopal-mahajan @ThorodanBrom Yes we can remove the triggers as of now and add it later on as a separate migration as and when required. @gopal-mahajan Just tp confirm, does created_at and updated_at fields/columns necessary for jobs table?

Sure i will remove the triggers for now. Yes @code-akki we need the created_at and updated_at as it is required for the job status api response.

@ThorodanBrom ThorodanBrom merged commit ffc439f into datakaveri:main Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants