Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script-for-column-update #109

Merged
merged 3 commits into from
Apr 30, 2024
Merged

script-for-column-update #109

merged 3 commits into from
Apr 30, 2024

Conversation

gopal-mahajan
Copy link
Collaborator

No description provided.

@jenkins-datakaveri
Copy link

Build finished.

ThorodanBrom
ThorodanBrom requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@ThorodanBrom ThorodanBrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. You can add an index on crs_id in collection_supported_crs since there will be joins on that key.

@jenkins-datakaveri
Copy link

Build finished.

ThorodanBrom
ThorodanBrom requested changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@ThorodanBrom ThorodanBrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name needs to be V8__..., 2 underscores after version number

@ThorodanBrom
Copy link
Collaborator

retest this please

@jenkins-datakaveri
Copy link

Build finished.

1 similar comment
@jenkins-datakaveri
Copy link

Build finished.

@ThorodanBrom ThorodanBrom merged commit d4c79dc into datakaveri:main Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThorodanBrom ThorodanBrom ThorodanBrom requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gopal-mahajan @jenkins-datakaveri @ThorodanBrom