Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cascade option for delete and other fixes #88

Merged
merged 5 commits into from
Feb 25, 2021

Conversation

guzman-raphael
Copy link
Collaborator

@guzman-raphael guzman-raphael commented Feb 25, 2021

  • Remove CRUD references. (Fix Replace CRUD references in docs #84)
  • Replace unnecessary snake_to_camel_case method with datajoint.utils.to_camel_case.
  • Replace schema_virtual_module term for table information. (Fix Replace schema_virtual_module from definition #85)
  • Allow cascade argument for delete operations. Defaults to false. When a delete is attempted on a record with a foreign key reference, returns status code of 409 with parsed result like so:
    {
      "error": "IntegrityError",
      "error_msg": "Full exception message goes here, blah, blah, ...",
      "child_schema": "alpha_company",
      "child_table": "Employee"
    }
    Otherwise will return 200 as before when successful or 500 for unhandled exceptions. (Fix Modify delete operation to delete_quick #86)
  • Add documentation related to bearer token security issue when deploying on a server. (Fix Document JWT security warning to prevent misuse #83)
  • Consolidate/Optimize fixtures for reuse in tests.
  • Increased code coverage to 81%.

…ated to virtual module describe, allow cascade argument for delete, add doc related to bearer token security issue, when non-cascade delete fails return parsed child problem, consolidate and optimize tests.
@guzman-raphael guzman-raphael added this to the Beta Release Candidate milestone Feb 25, 2021
@guzman-raphael guzman-raphael marked this pull request as ready for review February 25, 2021 00:43
@guzman-raphael guzman-raphael changed the title Allow cascade option for delete Allow cascade option for delete and other fixes Feb 25, 2021
Copy link
Contributor

@Synicix Synicix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes

pharus/interface.py Show resolved Hide resolved
tests/test_delete.py Outdated Show resolved Hide resolved
@Synicix Synicix merged commit 19db7c1 into datajoint:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants