Update dynamic api to support sci viz templating for real time views #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e component library.
Simplify logic to make it easier for others to contribute to the component library
Add sensitive info support
guzman-raphael
requested changes
Jan 21, 2022
There was a problem hiding this comment.
@jverswijver Excellent work here and great to collaborate with you on this! 🙏
Would you update the following so we can move closer to a merge?
- Flip the PR to
Ready for review - Update
CHANGELOG.mdwith appropriate entries for the contributions here
Also, we can include:
- Utilize
otumat watchfor the hot-reload - Use
blackfor autoformatting - Rename the spec sheet environment variable with a prefix of
PHARUS_ - Remove now unnecessary DOCKER environment variables in GH Actions
To help implement the above, I have created this PR to your fork.
Use `otumat watch` and `black` for autoformatting
Fix tests that broke due to `black` and optimize GH Actions
…harus into update_dynamic_api
Readd `flake8` to style tests
guzman-raphael
approved these changes
Jan 21, 2022
|
@jverswijver Way to go on this one man! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.