-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix declaration of get_miniscope_root_data_dir
#54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please update the version and CHANGELOG.
These modifications don't require a version update. |
Is not a patch release? |
Based on internal agreement, there is no requirement to release a new version for these changes. |
I haven't agreed to that. In the future please do one of the following:
|
Thank you for underscoring the importance of maintaining clear practices for our open-source repositories. Here's a concise update on the ongoing discussion: Initially, following guidance from our Slack channel, we determined that a version bump isn't necessary after a PR review in notebooks, README, and tutorial_pipeline.py. However, this PR conversation has sparked an ongoing discussion on best practices for versioning and changelog management, with forthcoming documentation from @kushal. Additionally, we are exploring the adoption of the conventional commit vscode extension. Given that this discussion is still pending resolution, I plan to manually bump the CHANGELOG and version following Kushal's guidance, and will include these details in the PR description. We remain open to considering alternative methods, such as the potential auto-generation of the CHANGELOG using VSCode extensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MilagrosMarin!
This PR initially aimed to correct minor typos, changing
imaging_root_data_dir
tominiscope_root_data_dir
intutorial_pipeline.py
.Following the review, a discussion has sparked on our approach to version and CHANGELOG updates across open-source repositories. The version and CHANGELOG in this PR have been manually updated for the time being, pending forthcoming documentation that will guide future version and changelog updates in subsequent PRs.