-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error when altering Part table that uses "master" keyword #991
Conversation
This solution does not handle the case of a part table using the "master" keyword in a more complex way, though. @schema
class Probe(dj.Manual):
definition = """
id: int
"""
class Shank(dj.Part):
definition = """
-> master
"""
class Electrode(dj.Part):
definition = """
-> master.Shank
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rly Thank you for contributing to the fix! 💪
We appreciate your patience with our review but we've finally opened up some bandwidth to work through our PR queue.
Suggesting an alternative approach.
Thanks for taking a look at this PR. This issue comes up in the Frank Lab often. Syntax, integration, and style checks pass. Thanks for the comprehensive developer documentation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rly Np. 🍻
Most of all, thanks to contributors like you for your help! LGTM
Fix #936.
The core of the issue appears to be that the "master" keyword in the Part table definition does not match the name of a table in
context
. So in this PR, I updatealter
only for Part tables so that "master" refers to the master table incontext
. There may be a more elegant way to fix this issue, but this seems to do the trick.