PLAT-154: Migrate test_external #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ethho
commented
Dec 11, 2023
ethho
commented
- cp to tests
- nose2pytest test_external
- Use pytest tmpdir fixtures for mocking stores
- Migrate test_external
- Format with black
This was referenced Dec 11, 2023
A-Baji
reviewed
Dec 12, 2023
| @@ -176,23 +175,52 @@ def connection_test(connection_root): | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def stores_config(): | |||
| def stores_config(tmpdir_factory): | |||
There was a problem hiding this comment.
Could you explain tmpdir_factory for me?
There was a problem hiding this comment.
It's similar to the builtin tmpdir, except that it's a fixture that will ensure that the temp dirs for different tests have different base directories. Not as important in this case, since the fixture is session-scoped, but if we changed the scope to function this would be important.
https://docs.pytest.org/en/6.2.x/tmpdir.html#the-tmpdir-factory-fixture
A-Baji
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.