feat(frontend): align frontend sso code with refactors #9506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Dec 26, 2023
| if (!_ssoManager.isSsoEnabled()) { | ||
| return false; | ||
| } | ||
| updateConfig(); |
There was a problem hiding this comment.
My original impression was that this was doing a refresh of the SSO provider by fetching configs from the backend... Is that no longer required?
There was a problem hiding this comment.
Do you mean the OIDC backend or GMS? There is separate logic to pull the configuration from GMS in SSOManager.getDynamicSettings which calls out to the AuthServiceController and the OIDC backend update happens in a separate flow controlled by AuthenticationController
jjoyce0510
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist