Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop ingestion-smoke CI errors on forks #9160

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 1, 2023

Every PR that comes from a fork gets spammed with a "ingestion smoke" workflow failed email. While the workflow is disabled for datahub-project, forks aren't spared.

If we need this in a private elsewhere, we can just tweak the if condition to be publish == 'true' || repo = 'org/name' as needed.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from anshbansal November 1, 2023 23:30
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Nov 1, 2023
@hsheth2 hsheth2 requested review from david-leifker and removed request for anshbansal November 1, 2023 23:30
@hsheth2 hsheth2 changed the title chore: stop ingestion-smoke errors on forks chore: stop ingestion-smoke CI errors on forks Nov 1, 2023
@hsheth2 hsheth2 merged commit 4a4c290 into datahub-project:master Nov 6, 2023
@hsheth2 hsheth2 deleted the ingestion-smoke branch November 6, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants