Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add --write args on pre-commit prettier #8560

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix: add --write args on pre-commit prettier #8560

merged 1 commit into from
Aug 3, 2023

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

This will automatically modify the files that are out of format with prettier when running pre-commit.

@yoonhyejin yoonhyejin requested a review from jjoyce0510 August 3, 2023 05:01
@yoonhyejin yoonhyejin merged commit de9f49a into master Aug 3, 2023
@yoonhyejin yoonhyejin deleted the fix/pre-commit branch August 3, 2023 22:47
yoonhyejin added a commit that referenced this pull request Aug 24, 2023
@yoonhyejin
fix: add --write args on pre-commit prettier (#8560)
2077497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @jjoyce0510