Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/okta): Set default of okta_profile_to_username_attr to email #8263

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/how/updating-datahub.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
### Breaking Changes

- #8201: Python SDK: In the DataFlow class, the `cluster` argument is deprecated in favor of `env`.
- #8263: Okta source config option `okta_profile_to_username_attr` default changed from `login` to `email`.
This determines which Okta profile attribute is used for the corresponding DataHub user
and thus may change what DataHub users are generated by the Okta source.

### Potential Downtime

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class OktaConfig(StatefulIngestionConfigBase, ConfigModel):
# Optional: Customize the mapping to DataHub Username from an attribute appearing in the Okta User
# profile. Reference: https://developer.okta.com/docs/reference/api/users/
okta_profile_to_username_attr: str = Field(
default="login",
default="email",
description="Which Okta User Profile attribute to use as input to DataHub username mapping. Common values used are - login, email.",
)
okta_profile_to_username_regex: str = Field(
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/tests/integration/okta/test_okta.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_okta_config():
assert config.ingest_users is True
assert config.ingest_groups is True
assert config.ingest_group_membership is True
assert config.okta_profile_to_username_attr == "login"
assert config.okta_profile_to_username_attr == "email"
assert config.okta_profile_to_username_regex == "([^@]+)"
assert config.okta_profile_to_group_name_attr == "name"
assert config.okta_profile_to_group_name_regex == "(.*)"
Expand Down