-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add combined health check endpoint which can check multiple components #8191
Conversation
...ervice/health-servlet/src/main/java/com/datahub/health/controller/HealthCheckController.java
Outdated
Show resolved
Hide resolved
...ervice/health-servlet/src/main/java/com/datahub/health/controller/HealthCheckController.java
Outdated
Show resolved
Hide resolved
...ervice/health-servlet/src/main/java/com/datahub/health/controller/HealthCheckController.java
Outdated
Show resolved
Hide resolved
Couple minor comments, once this gets into a release lets be sure update the readiness probe here and make sure it works as expected. |
Example usages: Base endpoint: http://localhost:8080/health/check/ready
Check Elastic component explicitly: http://localhost:8080/health/check/ready?checks=elasticsearch Check non-existent component: http://localhost:8080/health/check/ready?checks=hello
Check existent and non-existent component: http://localhost:8080/health/check/ready?checks=hello,elasticsearch
|
So far, only checks ElasticSearch client, the first one we implemented
Example response on quickstart for URL: http://localhost:8080/health/check/combined
200 response with body
Checklist